[18.0][MIG] account_statement_import_camt: Migration to 18.0 by xaviedoanhduy · Pull Request #737 · OCA/bank-statement-import

xaviedoanhduy · 2024-11-08T10:23:26Z

depends on:

base on:

[17.0][MIG] account_statement_import_camt: Migration to 17.0 #684

on this occasion:

move test_files folder in tests and rename it to sample with the same convention in:

bank-statement-import/.pre-commit-config.yaml

Line 20 in a919f9b

/tests/samples/.*|

grindtildeath · 2024-12-17T18:45:08Z

@xaviedoanhduy Can you rebase after merging other PRs?

xaviedoanhduy · 2024-12-17T23:18:22Z

@xaviedoanhduy Can you rebase after merging other PRs?

hi @grindtildeath, done!

sebalix

Seems like bot commits were merged in some author commits (like unrelated translation files merged in Spanish translation contribution).

Maybe you used the feature in development there? OCA/oca-port#66 (just a guess). I would consider this feature not stable enough for the moment. IMO such commits should be squashed together (bots commits into another bot commit, to not mix contributors & contributions).

If you are unsure, better to preserve the 17.0 history as-is.

xaviedoanhduy · 2025-01-23T10:03:23Z

Seems like bot commits were merged in some author commits (like unrelated translation files merged in Spanish translation contribution).

Maybe you used the feature in development there? OCA/oca-port#66 (just a guess). I would consider this feature not stable enough for the moment. IMO such commits should be squashed together (bots commits into another bot commit, to not mix contributors & contributions).

If you are unsure, better to preserve the 17.0 history as-is.

hi @sebalix, I don't use the feature you mentioned. I just squash the administrative commits manually following this guide: https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

sebalix · 2025-03-06T09:16:21Z

@xaviedoanhduy thanks! All good then, as soon as the commit message of contributors doesn't change it's OK (oca-port is using this criteria to detect missing commits in a target branch).

LG.

xaviedoanhduy · 2025-03-11T05:16:17Z

please merge this PR to make the CI green: #785

BT-dmoreno · 2025-04-10T09:12:04Z

@xaviedoanhduy the tests are failing but I don't think because of an error of the code proposed by this PR, any idea why they got stuck like that? Maybe re-running them can help in case was due to a temporal GH failure?

Currently translated at 75.0% (9 of 12 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_camt Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_camt/nl/

Currently translated at 83.3% (10 of 12 strings) Translation: bank-statement-import-14.0/bank-statement-import-14.0-account_statement_import_camt Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-14-0/bank-statement-import-14-0-account_statement_import_camt/it/

@ccy

Encountered in a Camt.054 statement: currency listed under /BkToCstmrDbtCdtNtfctn/Ntfctn/Ntry/Amt/@ccy

with this commit, the narration field is filled with infos find in the camt file such as reversal indicator, return reason, cheque number, ... before only a banking ref was present. The transaction type field is also filled.

Currently translated at 100.0% (12 of 12 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/es/

Currently translated at 100.0% (31 of 31 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/es/

Currently translated at 22.5% (7 of 31 strings) Translation: bank-statement-import-16.0/bank-statement-import-16.0-account_statement_import_camt Translate-URL: https://translation.odoo-community.org/projects/bank-statement-import-16-0/bank-statement-import-16-0-account_statement_import_camt/it/

This refactoring will allow using `TestParser._do_parse_test()` method for subclasses defined in inheriting modules. This way, if the new module defines new files in other paths than `account_statement_import_camt/test_files/`, subclasses of `TestParser` will still be able to use the `_do_parse_test()` method for imports and checks. Moreover, a custom value can now be defined for the acceptable differing lines number between inputfile and goldenfile. It will also maintain backward compatibility with the current usage of the method (ie: using only a filename with the assumption of finding it in `account_statement_import_camt/test_files/`). NB: methods are now defined outside of `TestParser` to allow importing them directly, instead of inheriting from `TestParser`.

BT-dmoreno · 2025-04-10T09:25:11Z

@OCA/banking-maintainers could you please take a look at this and merge it if you consider, thanks!

etobella

Technically looks good. The relevant changes are related to transformation from % to format.

OCA-git-bot · 2025-04-10T09:32:44Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

etobella · 2025-04-10T09:32:47Z

/ocabot merge nobump

OCA-git-bot · 2025-04-10T09:32:56Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-737-by-etobella-bump-nobump, awaiting test results.

OCA-git-bot · 2025-04-10T09:41:23Z

Congratulations, your PR was merged at 12a9b2e. Thanks a lot for contributing to OCA. ❤️

BT-dmoreno · 2025-04-10T09:43:30Z

Thanks @xaviedoanhduy for having pushed those commits a while ago and being pro-active 🥇.

StefanRijnhart · 2025-04-10T09:43:52Z

            # pylint: disable=except-pass
            except (zipfile.BadZipFile, ValueError):
-                pass
+                _logger.exception("BadZipfile exception")


Why is an exception logged now instead of ignored? This code will run on any file that is not a valid camt file, i.e. any file of any other format supported by the import framework.

Signed-off-by etobella

xaviedoanhduy mentioned this pull request Nov 11, 2024

[18.0][MIG] account_statement_import_camt54: Migration to 18.0 #738

Merged

xaviedoanhduy force-pushed the 18.0-mig-account_statement_import_camt branch from 9c01fca to 180fce9 Compare November 14, 2024 05:14

henrybackman approved these changes Dec 6, 2024

View reviewed changes

xaviedoanhduy force-pushed the 18.0-mig-account_statement_import_camt branch from 180fce9 to b686079 Compare December 17, 2024 23:15

sebalix suggested changes Jan 23, 2025

View reviewed changes

TDu reviewed Jan 29, 2025

View reviewed changes

Comment thread account_statement_import_camt/models/account_statement_import_camt_parser.py Outdated

xaviedoanhduy force-pushed the 18.0-mig-account_statement_import_camt branch from b686079 to 0a3fa7b Compare January 29, 2025 15:29

psugne mentioned this pull request Feb 5, 2025

[18.0][MIG] account_statement_import_camt: Migration to 18.0 versada/bank-statement-import#3

Merged

ivantodorovich approved these changes Feb 12, 2025

View reviewed changes

Comment thread account_statement_import_camt/models/account_journal.py Outdated

sebalix approved these changes Mar 6, 2025

View reviewed changes

OCA-git-bot added the approved label Mar 6, 2025

xaviedoanhduy force-pushed the 18.0-mig-account_statement_import_camt branch from 0a3fa7b to 8825f3a Compare March 11, 2025 05:08

xaviedoanhduy mentioned this pull request Mar 26, 2025

Migration to version 18.0 #725

Open

12 tasks

i-vyshnevska and others added 11 commits April 10, 2025 16:16

[MIG][14.0] account_statement_import_camt_oca

b54803d

[14.0][FIX]camt import

891739c

[FIX] Fix same eror in camt54 module

a132acd

account_statement_import_camt 14.0.1.1.0

e0e88b6

Added translation using Weblate (Italian)

8702a87

[MIG] account_statement_import_camt: Migration to 15.0

5cf5f25

[IMP] account_statement_import_camt: look for currency under Ntry

834a4f0

Encountered in a Camt.054 statement: currency listed under /BkToCstmrDbtCdtNtfctn/Ntfctn/Ntry/Amt/@ccy

account_statement_import_camt - fix counterparty data

3aa4d90

luc-demeyer and others added 11 commits April 10, 2025 16:16

fix camt unit tests

4f9f7c4

[16.0][MIG] account_statement_import_camt: Migrate to version 16.0

a07e2c6

[BOT] post-merge updates

43c2c23

[IMP] account_statement_import_camt: pre-commit auto fixes

7929f45

[MIG] account_statement_import_camt: Migration to 17.0

a4e6f4c

[IMP] account_statement_import_camt: pre-commit auto fixes

67c2a56

[MIG] account_statement_import_camt: Migration to 18.0

1334327

xaviedoanhduy force-pushed the 18.0-mig-account_statement_import_camt branch from 8825f3a to 1334327 Compare April 10, 2025 09:16

etobella approved these changes Apr 10, 2025

View reviewed changes

OCA-git-bot added the ready to merge label Apr 10, 2025

OCA-git-bot added the bot is merging ⏳ label Apr 10, 2025

OCA-git-bot merged commit 9e1ac84 into OCA:18.0 Apr 10, 2025
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Apr 10, 2025

StefanRijnhart reviewed Apr 10, 2025

View reviewed changes

BhaveshHeliconia pushed a commit to HeliconiaIO/bank-statement-import that referenced this pull request Mar 20, 2026

Merge PR OCA#737 into 18.0

8f83507

Signed-off-by etobella

Uh oh!

Conversation

xaviedoanhduy commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

depends on:

base on:

on this occasion:

Uh oh!

grindtildeath commented Dec 17, 2024

Uh oh!

xaviedoanhduy commented Dec 17, 2024

Uh oh!

sebalix left a comment

Choose a reason for hiding this comment

Uh oh!

xaviedoanhduy commented Jan 23, 2025

Uh oh!

Uh oh!

Uh oh!

sebalix commented Mar 6, 2025

Uh oh!

xaviedoanhduy commented Mar 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BT-dmoreno commented Apr 10, 2025

Uh oh!

BT-dmoreno commented Apr 10, 2025

Uh oh!

etobella left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Apr 10, 2025

Uh oh!

etobella commented Apr 10, 2025

Uh oh!

OCA-git-bot commented Apr 10, 2025

Uh oh!

Uh oh!

OCA-git-bot commented Apr 10, 2025

Uh oh!

BT-dmoreno commented Apr 10, 2025

Uh oh!

StefanRijnhart Apr 10, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

xaviedoanhduy commented Nov 8, 2024 •

edited

Loading

xaviedoanhduy commented Mar 11, 2025 •

edited

Loading